nortti
/
sortix-mirror
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Change strverscmp(3) non-digit behavior to match GNU sort -V. 

This behavior differs from glibc strverscmp(3) but is useful and matches
the behavior of GNU sort -V and musl strverscmp(3.
This commit is contained in:
Jonas 'Sortie' Termansen 2022-07-09 15:59:58 +02:00
parent 802b0ef1d1
commit 85e9fcde94
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libc/string/strverscmp.c
View File

@ -41,7 +41,12 @@ int strverscmp(const char* a, const char* b)
continue;
// Be a regular strcmp if no digits are involed when they differ.
bool version_string = is_number(a[i]) && is_number(b[i]);
// Note: This implementation uses version number comparison if *either*
// of the first differing characters are digits, unlike glibc
// which is documented to require *both*. This behavior matches
// GNU sort -V and musl. It's also useful as "1.2.txt" compares
// before "1.2.3.txt".
bool version_string = is_number(a[i]) || is_number(b[i]);
if ( !version_string && a[i] < b[i] )
return -1;
if ( !version_string && a[i] > b[i] )