From dc1f1050d56e172eeb5615d48e387718e4494501 Mon Sep 17 00:00:00 2001
From: Nick Chambers <nchambers@lightspeedsystems.com>
Date: Sat, 19 Jun 2021 02:05:14 -0500
Subject: [PATCH 1/2] Add more debug statements

---
 rowbot | 39 ++++++++++++++++++++-------------------
 1 file changed, 20 insertions(+), 19 deletions(-)

diff --git a/rowbot b/rowbot
index 0f2c43f..f2abcf2 100755
--- a/rowbot
+++ b/rowbot
@@ -133,6 +133,17 @@ cleanup() {
 
 trap cleanup EXIT
 
+alarm-handler() {
+  ping "row your bot gently down the stream"
+
+  if [[ $keep_trying = yes ]]; then
+    info "trying for %s again" "$desired_nick"
+    nick "$desired_nick"
+  fi
+}
+
+trap alarm-handler ALRM
+
 ###
 # reload code
 ###
@@ -272,10 +283,14 @@ on_001() {
     join "$chan"
   fi
 
-  while true; do
-    kill -ALRM "$$"
-    sleep 10
-  done &
+  {
+    debug "timer pid is %d" "$BASHPID"
+
+    while true; do
+      kill -ALRM "$$"
+      sleep 10
+    done
+  } &
 
   ping_pid=$!
   nick=${params[0]}
@@ -477,21 +492,6 @@ who() {
   fi
 }
 
-###
-# keepalive code
-###
-
-alarm-handler() {
-  ping "row your bot gently down the stream"
-
-  if [[ $keep_trying = yes ]]; then
-    info "trying for %s again" "$desired_nick"
-    nick "$desired_nick"
-  fi
-}
-
-trap alarm-handler ALRM
-
 ###
 # app hooks
 ##
@@ -709,6 +709,7 @@ if [[ $reload = yes ]]; then
   privmsg "$RELOAD_TO" done.
 else
   registered=no
+  info "rowbot's pid is %d" "$$"
   nick "$nick"
   user "$ident" "$realname"
 fi

From 17ae68117992afa60fa6364a63d03d43b7f4df77 Mon Sep 17 00:00:00 2001
From: Nick Chambers <nchambers@lightspeedsystems.com>
Date: Sat, 19 Jun 2021 02:15:20 -0500
Subject: [PATCH 2/2] Fix accidental expansions causing pm bugs

---
 rowbot | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rowbot b/rowbot
index f2abcf2..f7aad10 100755
--- a/rowbot
+++ b/rowbot
@@ -117,11 +117,11 @@ fi
 ###
 
 cleanup() {
-  if [[ -v $tls_pid || $tls = no ]]; then
+  if [[ -v tls_pid || $tls = no ]]; then
     exec {in_sock}>&- {out_sock}>&- {log}>&-
   fi
 
-  if [[ -v $tls_pid ]]; then
+  if [[ -v tls_pid ]]; then
     kill "$tls_pid"
     rm -rf "$sock_dir"
   fi